Feature/add filter by text value feature #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
⚙️ branches
app:
Origin: feature/add_filter_by_text_value_feature Target: 2.0.0_beta
dhis2-android-SDK:
Origin: 056d6e33d3204f8514bf438bc3af6876feeb9a4e
dhis2-rule-engine:
Origin: master
🎩 What is the goal?
Add a filter by value (only for text data elements).
📝 How is it being implemented?
Note: Filters is for all screens because the FilterManager is a singleton. But the value filter for the moment is only for program events, then filter value is cleared when you navigate to the previous screen.
For success build It's neccessary add this build gradle to dhis2-rule-engine:
💥 How can it be tested?
Use case 1: - Navigate to events for program Yaws - case register (Yaws/003) then create value filter and should work and increment text value filter counter and general filter counter.
Use case 2: - When you navigate back to the first screen, the value filter should be cleared
Use case 3: - When you have all filters and click on clear filters, the value filter should be cleared like the rest.
Use case 3: - When you have a text value filter and remove the text, the filter counters should be cleared.
💾 Requires DB migration?
🎨 UI changes?